Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

110823: Add facets and meta tags to PR template #822

Merged
merged 2 commits into from
Nov 9, 2023
Merged

110823: Add facets and meta tags to PR template #822

merged 2 commits into from
Nov 9, 2023

Conversation

ccho-mongodb
Copy link
Contributor

Pull Request Info

PR Reviewing Guidelines

JIRA - None
Staging - None

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

norareidy
norareidy approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although Rea's comment on this PR would apply here too (if you take her suggestion)

@ccho-mongodb ccho-mongodb merged commit 41267cb into mongodb:master Nov 9, 2023
@ccho-mongodb ccho-mongodb deleted the 110823-add-facets-pr-template branch November 9, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norareidy norareidy norareidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccho-mongodb @norareidy